Skip to content

Conversation

@davidylee
Copy link
Contributor

@davidylee davidylee commented Oct 19, 2021

Checklist:

Closes freeCodeCamp/freeCodeCamp#43910

Creating a copy of the latest branch version with git branch v1.0.0 upstream/v1.0.0 did not work... I used 'origin' instead of 'upstream' and proceeded with the coderoad build and hopefully it worked.

@ilenia-magoni
Copy link

Make sure you put the link to the issue, as it is in a different repository the linking doesn't work with just the number.

Also make sure you follow the guidelines and ask questions if needed, making changes to main doesn't change the version

@davidylee
Copy link
Contributor Author

Here is the link freeCodeCamp/freeCodeCamp#43910

I see. The version number v1.0.1 was just to create a branch off main. Is there something I did incorrectly here? Thanks for your help.

@gikf gikf mentioned this pull request Oct 20, 2021
2 tasks
@gikf gikf changed the title V1.0.1 fix: corrected wording Oct 20, 2021
Copy link
Member

@gikf gikf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems everything is good! 👍

@davidylee
Copy link
Contributor Author

Hi @gikf would you be able to add hacktoberfest-accepted label ? I'm trying to get qualifying PRs.

Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @davidylee 🎉 Thanks for contributing to freeCodeCamp 🎉

@moT01 moT01 merged commit 35faddc into freeCodeCamp:main Oct 27, 2021
@moT01 moT01 mentioned this pull request Oct 27, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Learn Bash Scripting by Building Five Programs - minor corrections to text

4 participants