Skip to content

Conversation

@akshat-o5
Copy link

@akshat-o5 akshat-o5 commented Jan 9, 2022

… Five Programs is solved

Checklist:

Closes freeCodeCamp/freeCodeCamp#44731

Copy link
Member

@gikf gikf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tutorial is using CodeRoad VS Code extension, specific guidelines how to contribute to them can be found on https://contribute.freecodecamp.org/#/how-to-work-on-tutorials-that-use-coderoad. Making PR for this issue will require following parts referring to making changes on the main branch.

Please make sure you read our guidelines for contributing, we prioritize contributors following the instructions in our guides. Join us in our chat room or the forum if you need help contributing, our moderators will guide you through this.

Sometimes we may get more than one pull requests. We typically accept the most quality contribution followed by the one that is made first.

Happy contributing.

@akshat-o5
Copy link
Author

Okay, I will rectify it.

@akshat-o5
Copy link
Author

I had made changes on the main branch. Please refer it.

@gikf
Copy link
Member

gikf commented Jan 9, 2022

I'm not seeing any new commits here, did you remember to push new changes?

@akshat-o5
Copy link
Author

I had done , please refer it.

@akshat-o5
Copy link
Author

I have created another pull reuqest , please see to it.

@gikf
Copy link
Member

gikf commented Jan 9, 2022

Please follow guidelines I linked before. Further changes should be done on this branch, pushing commit to it will automatically update PR.

@akshat-o5
Copy link
Author

Due to some error, I am not being able to commit in this PR again. If you close this , I will make a new PR with all the necessary changes required.

@akshat-o5 akshat-o5 requested a review from gikf January 10, 2022 15:52
@gikf
Copy link
Member

gikf commented Jan 11, 2022

What error? If you need help contributing join us in our chat room or the forum, moderators will guide you through this.

@moT01
Copy link
Member

moT01 commented Jan 24, 2022

Thanks for the PR @akshat-o5 - this was fixed with another one so I am going to close it. Happy coding 🎉

@moT01 moT01 closed this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in Lesson 10 in Learn Bash Scripting by Building Five Programs

3 participants