Skip to content

Conversation

@jayrm
Copy link
Member

@jayrm jayrm commented Jul 14, 2019

Some tests in the test suite are incorrect and fail.

This has occurred because tests/fbc-tests.bas exits with a non-zero exit code only if tests fail to run, or there is a failed internal check. Failed tests on their own do not produce a non-zero (error) exit code.

  • update fbcunit to version 0.8 and produce a non-zero (error) exit code if any test (assert) fails
  • va_list typedef in inc/crt/stdarg.bi should be type va_list as cva_list
  • some tests for va_first, va_next, and va_arg are enabled for -gen gcc in windows. This is from an older version of varargs updates that allowed these macros for -gen gcc in windows, which appear to pass in local testing, but to date, found no documentation that guarantees it would always work. They are reverted to only be enabled with -gen gas
  • method for testing space " " in tests/wstring/print.bas is incorrect and will fail
  • tests/udt-zstring/swap.bas and tests/udt-zstring/str.bas have some tests that were incorrectly translated from tests/udt-wstring, and fail.

jayrm added 5 commits July 13, 2019 19:09
- appears to be some bad conversion from udt-wstring tests
- remove wstring tests from tests/udt-zstring/swap.bas
- modify wchar to char literals in tests/udt-zstring/str.bas
@jayrm jayrm merged commit 27832b2 into freebasic:master Jul 14, 2019
@jayrm jayrm deleted the fbc-tests branch July 14, 2019 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant