Skip to content

fix or remove invalid tests in fbc test suite #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 14, 2019
Merged

fix or remove invalid tests in fbc test suite #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd6a6bb
fbc-tests: enable old vararg tests only if -gen gas
jayrm Jul 7, 2019
6b61ea5
fbc-tests: tests/wstring/print.bas: remove test for whitespace with i…
jayrm Jul 13, 2019
6f36ece
fbc-tests: tests/udt-zstring
jayrm Jul 13, 2019
27c4cc9
fbcunit: run_tests() returns false (failed) if any one assert fails
jayrm Jul 14, 2019
a6e5e23
fbcunit: update to version 0.8
jayrm Jul 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inc/crt/stdarg.bi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
#ifndef __crt_stdarg_bi__
#define __crt_stdarg_bi__

type va_list as any ptr
type va_list as cva_list

#endif
6 changes: 6 additions & 0 deletions tests/fbcunit/changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
Version 0.8

[changed]
- run_tests() returns false (failed) if any one assert fails


Version 0.7

[added]
Expand Down
4 changes: 2 additions & 2 deletions tests/fbcunit/inc/fbcunit.bi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#define __FBCUNIT_BI_INCLUDE__ 1

'' fbcunit - FreeBASIC Compiler Unit Testing Component
'' Copyright (C) 2017-2018 Jeffery R. Marshall (coder[at]execulink[dot]com)
'' Copyright (C) 2017-2019 Jeffery R. Marshall (coder[at]execulink[dot]com)
''
'' License: GNU Lesser General Public License
'' version 2.1 (or any later version) plus
Expand All @@ -13,7 +13,7 @@
---------------------------------------------------------'/

#define FBCU_VER_MAJOR 0
#define FBCU_VER_MINOR 7
#define FBCU_VER_MINOR 8

#inclib "fbcunit"

Expand Down
2 changes: 1 addition & 1 deletion tests/fbcunit/license.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
fbcunit - FreeBASIC Compiler Unit Testing Component
Copyright (C) 2017-2018 Jeffery R. Marshall (coder[at]execulink[dot]com)
Copyright (C) 2017-2019 Jeffery R. Marshall (coder[at]execulink[dot]com)

This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
Expand Down
4 changes: 2 additions & 2 deletions tests/fbcunit/readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
fbcunit - FreeBASIC Compiler Unit Testing Component
Copyright (C) 2017-2018 Jeffery R. Marshall (coder[at]execulink[dot]com)
Copyright (C) 2017-2019 Jeffery R. Marshall (coder[at]execulink[dot]com)

fbcunit version 0.7
fbcunit version 0.8
-------------------
Unit testing component for fbc compiler. Provides macros
and common code for unit testing fbc compiled sources.
Expand Down
6 changes: 5 additions & 1 deletion tests/fbcunit/src/fbcunit.bas
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'' fbcunit - FreeBASIC Compiler Unit Testing Component
'' Copyright (C) 2017-2018 Jeffery R. Marshall (coder[at]execulink[dot]com)
'' Copyright (C) 2017-2019 Jeffery R. Marshall (coder[at]execulink[dot]com)
''
'' License: GNU Lesser General Public License
'' version 2.1 (or any later version) plus
Expand Down Expand Up @@ -607,6 +607,10 @@ namespace fbcu

fbcu_test_index = .test_index_next

if( .assert_pass_count <> .assert_count ) then
failed = true
end if

end with

wend
Expand Down
6 changes: 1 addition & 5 deletions tests/functions/va_int_and_ptrs.bas
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
# include "fbcunit.bi"

#if defined( __FB_64BIT__ )
#if defined( __FB_WIN32__ )
#define DOTEST
#endif
#elseif (__FB_BACKEND__ = "gas")
#if (__FB_BACKEND__ = "gas")
#define DOTEST
#endif

Expand Down
6 changes: 1 addition & 5 deletions tests/functions/va_strings.bas
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
# include "fbcunit.bi"

#if defined( __FB_64BIT__ )
#if defined( __FB_WIN32__ )
#define DOTEST
#endif
#elseif (__FB_BACKEND__ = "gas")
#if (__FB_BACKEND__ = "gas")
#define DOTEST
#endif

Expand Down
6 changes: 1 addition & 5 deletions tests/functions/va_tmpstring.bas
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
# include "fbcunit.bi"

#if defined( __FB_64BIT__ )
#if defined( __FB_WIN32__ )
#define DOTEST
#endif
#elseif (__FB_BACKEND__ = "gas")
#if (__FB_BACKEND__ = "gas")
#define DOTEST
#endif

Expand Down
6 changes: 1 addition & 5 deletions tests/functions/var_args.bas
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
# include "fbcunit.bi"

#if defined( __FB_64BIT__ )
#if defined( __FB_WIN32__ )
#define DOTEST
#endif
#elseif (__FB_BACKEND__ = "gas")
#if (__FB_BACKEND__ = "gas")
#define DOTEST
#endif

Expand Down
8 changes: 4 additions & 4 deletions tests/udt-zstring/str.bas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,12 @@ SUITE( fbc_tests.udt_zstring_.str_ )

TEST( default )

dim s1 as zstring * 10 = chr(1234)
dim s2 as zstring * 10 = chr(1234)
dim s1 as zstring * 10 = chr(12)
dim s2 as zstring * 10 = chr(12)
dim s3 as zstring * 10 = str( s1 )

dim u1 as ustring = chr(1234)
dim u2 as ustring = chr(1234)
dim u1 as ustring = chr(12)
dim u2 as ustring = chr(12)
dim u3 as ustring = str( s1 )
dim u4 as ustring = wstr( u1 )

Expand Down
4 changes: 0 additions & 4 deletions tests/udt-zstring/swap.bas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,6 @@ SUITE( fbc_tests.udt_zstring_.swap_ )
check( "a", "a" )
check( "a", "abcdefghi" )

check( "", !"\u3041\u3043\u3045\u3047\u3049" )
check( "abc", !"\u3041\u3043\u3045\u3047\u3049" )
check( !"\u3045", !"\u3041\u3043\u3047\u3049" )

END_TEST

END_SUITE
2 changes: 1 addition & 1 deletion tests/wstring/print.bas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ SUITE( fbc_tests.wstring_.print_ )
OPEN_FILE( "print_strings.txt" )

check( "" )
check( " " )
'' check( " " ) '' can't test whitespace with INPUT
check( "0123456789" )
check( "ABCDEFGHIJKLMNOP" )
check( !"\u3041\u3043\u3045\u3047\u3049" )
Expand Down