Apply lint rules to Phabricator

Summary: Mostly applies a new call spacing rule; also a few things that have slipped through via pull requests and such

Test Plan: `find src/ -type f -name '*.php' | xargs -n16 arc lint --output summary --apply-patches`

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D5002

Author: epriestley

src/applications/audit/events/AuditPeopleMenuEventListener.php

@@ -28,8 +28,7 @@ private function handleMenuEvent($event) {
       ->setIsExternal(true)
       ->setName($name)
       ->setHref($href)
-      ->setKey($name)
-    );
+      ->setKey($name));
 
     $event->setValue('menu', $menu);
   }

src/applications/auth/ldap/PhabricatorLDAPProvider.php

@@ -269,13 +269,13 @@ public function search($query) {
 
     $rows = array();
 
-    for($i = 0; $i < $entries['count']; $i++) {
+    for ($i = 0; $i < $entries['count']; $i++) {
       $row = array();
       $entry = $entries[$i];
 
       // Get username, email and realname
       $username = $entry[$this->getSearchAttribute()][0];
-      if(empty($username)) {
+      if (empty($username)) {
         continue;
       }
       $row[] = $username;

src/applications/calendar/controller/PhabricatorCalendarBrowseController.php

@@ -44,8 +44,7 @@ public function processRequest() {
         $details = "\n\n".rtrim($status->getDescription());
       }
       $event->setDescription(
-        $status->getTerseSummary($user).$details
-      );
+        $status->getTerseSummary($user).$details);
       $event->setEventID($status->getID());
       $month_view->addEvent($event);
     }

src/applications/calendar/controller/PhabricatorCalendarDeleteStatusController.php

@@ -28,8 +28,7 @@ public function processRequest() {
       $uri->setQueryParams(
         array(
           'deleted' => true,
-        )
-      );
+        ));
       return id(new AphrontRedirectResponse())
         ->setURI($uri);
     }
@@ -40,12 +39,10 @@ public function processRequest() {
     $dialog->appendChild(phutil_tag(
       'p',
       array(),
-      pht('Permanently delete this status? This action can not be undone.')
-    ));
+      pht('Permanently delete this status? This action can not be undone.')));
     $dialog->addSubmitButton(pht('Delete'));
     $dialog->addCancelButton(
-      $this->getApplicationURI('status/edit/'.$status->getID().'/')
-    );
+      $this->getApplicationURI('status/edit/'.$status->getID().'/'));
 
     return id(new AphrontDialogResponse())->setDialog($dialog);
 

src/applications/calendar/controller/PhabricatorCalendarEditStatusController.php

@@ -85,8 +85,7 @@ public function processRequest() {
                                                        $user,
                                                        'Y'),
             $redirect => true,
-          )
-        );
+          ));
         return id(new AphrontRedirectResponse())
           ->setURI($uri);
       }
@@ -125,8 +124,7 @@ public function processRequest() {
     } else {
       $submit->addCancelButton(
         $this->getApplicationURI('status/delete/'.$status->getID().'/'),
-        pht('Delete Status')
-      );
+        pht('Delete Status'));
     }
     $form->appendChild($submit);
 
@@ -138,16 +136,14 @@ public function processRequest() {
         id(new PhabricatorHeaderView())->setHeader($page_title),
         $error_view,
         $form,
-      )
-    );
+      ));
 
     return $this->buildApplicationPage(
       $nav,
       array(
         'title' => $page_title,
         'device' => true
-      )
-    );
+      ));
   }
 
 }

src/applications/calendar/controller/PhabricatorCalendarViewStatusController.php

@@ -32,16 +32,14 @@ public function processRequest() {
       array(
         id(new PhabricatorHeaderView())->setHeader($page_title),
         $status_list,
-      )
-    );
+      ));
 
     return $this->buildApplicationPage(
       $nav,
       array(
         'title' => $page_title,
         'device' => true
-      )
-    );
+      ));
   }
 
   private function buildStatusList(array $statuses) {
@@ -62,8 +60,7 @@ private function buildStatusList(array $statuses) {
           array(
             'month' => $month,
             'year'  => $year,
-          )
-        );
+          ));
         $href = (string) $uri;
       }
       $from = phabricator_datetime($status->getDateFrom(), $user);
@@ -115,8 +112,7 @@ private function getPageTitle() {
     } else {
       $page_title = pht(
         'Upcoming Statuses for %s',
-        $this->getHandle($this->phid)->getName()
-      );
+        $this->getHandle($this->phid)->getName());
     }
     return $page_title;
   }

src/applications/calendar/view/AphrontCalendarMonthView.php

@@ -170,16 +170,14 @@ private function renderCalendarHeader(DateTime $date) {
       $prev_link = phutil_tag(
         'a',
         array('href' => (string) $uri->setQueryParams($query)),
-        "\xE2\x86\x90"
-      );
+        "\xE2\x86\x90");
 
       list($next_year, $next_month) = $this->getNextYearAndMonth();
       $query = array('year' => $next_year, 'month' => $next_month);
       $next_link = phutil_tag(
         'a',
         array('href' => (string) $uri->setQueryParams($query)),
-        "\xE2\x86\x92"
-      );
+        "\xE2\x86\x92");
 
       $left_th = phutil_tag('th', array(), $prev_link);
       $right_th = phutil_tag('th', array(), $next_link);

src/applications/config/controller/PhabricatorConfigAllController.php

@@ -91,8 +91,7 @@ public function processRequest() {
       array(
         'title' => $title,
         'device' => true,
-      )
-    );
+      ));
   }
 
 }

src/applications/config/controller/PhabricatorConfigGroupController.php

@@ -46,8 +46,7 @@ public function processRequest() {
       array(
         'title' => $title,
         'device' => true,
-      )
-    );
+      ));
   }
 
   private function buildOptionList(array $options) {

src/applications/config/controller/PhabricatorConfigIssueListController.php

@@ -41,8 +41,7 @@ public function processRequest() {
       array(
         'title' => $title,
         'device' => true,
-      )
-    );
+      ));
   }
 
   private function buildIssueList(array $issues) {