Simplify PHUIObjectBoxViews handling of Save and Error states

Summary: This removes the bulk of the "Form Errors" text, some variations likely exists. These are a bit redundant and space consuming. I'd also like to back ErrorView more into PHUIObjectBox.

Test Plan: Test out the forms, see errors without the text.

Reviewers: epriestley, btrahan

CC: Korvin, epriestley, aran, hach-que

Differential Revision: https://secure.phabricator.com/D7924

Author: chadlittle

resources/celerity/map.php

@@ -7,7 +7,7 @@
 return array(
   'names' =>
   array(
-    'core.pkg.css' => '3c41daee',
+    'core.pkg.css' => '9567aaae',
     'core.pkg.js' => 'c907bd96',
     'darkconsole.pkg.js' => 'ca8671ce',
     'differential.pkg.css' => '827749c1',
@@ -23,7 +23,7 @@
     'rsrc/css/aphront/context-bar.css' => '1c3b0529',
     'rsrc/css/aphront/dark-console.css' => '6378ef3d',
     'rsrc/css/aphront/dialog-view.css' => 'dd9db96c',
-    'rsrc/css/aphront/error-view.css' => '472968e0',
+    'rsrc/css/aphront/error-view.css' => 'ca515eae',
     'rsrc/css/aphront/lightbox-attachment.css' => '686f8885',
     'rsrc/css/aphront/list-filter-view.css' => '9577c6da',
     'rsrc/css/aphront/multi-column.css' => '05bbd016',
@@ -475,7 +475,7 @@
     'aphront-contextbar-view-css' => '1c3b0529',
     'aphront-dark-console-css' => '6378ef3d',
     'aphront-dialog-view-css' => 'dd9db96c',
-    'aphront-error-view-css' => '472968e0',
+    'aphront-error-view-css' => 'ca515eae',
     'aphront-list-filter-view-css' => '9577c6da',
     'aphront-multi-column-view-css' => '05bbd016',
     'aphront-notes' => '6acadd3f',

src/applications/auth/controller/PhabricatorAuthRegisterController.php

@@ -304,13 +304,6 @@ public function processRequest() {
       unset($unguarded);
     }
 
-    $error_view = null;
-    if ($errors) {
-      $error_view = new AphrontErrorView();
-      $error_view->setTitle(pht('Registration Failed'));
-      $error_view->setErrors($errors);
-    }
-
     $form = id(new AphrontFormView())
       ->setUser($request->getUser());
 
@@ -424,7 +417,7 @@ public function processRequest() {
     $object_box = id(new PHUIObjectBoxView())
       ->setHeaderText($title)
       ->setForm($form)
-      ->setFormError($error_view);
+      ->setFormErrors($errors);
 
     return $this->buildApplicationPage(
       array(

src/applications/auth/controller/config/PhabricatorAuthEditController.php

@@ -153,10 +153,6 @@ public function processRequest() {
       $issues = array();
     }
 
-    if ($errors) {
-      $errors = id(new AphrontErrorView())->setErrors($errors);
-    }
-
     if ($is_new) {
       $button = pht('Add Provider');
       $crumb = pht('Add Provider');
@@ -302,7 +298,7 @@ public function processRequest() {
 
     $form_box = id(new PHUIObjectBoxView())
       ->setHeaderText($title)
-      ->setFormError($errors)
+      ->setFormErrors($errors)
       ->setForm($form);
 
     return $this->buildApplicationPage(

src/applications/auth/controller/config/PhabricatorAuthNewController.php

@@ -37,10 +37,6 @@ public function processRequest() {
       }
     }
 
-    if ($errors) {
-      $errors = id(new AphrontErrorView())->setErrors($errors);
-    }
-
     $options = id(new AphrontFormRadioButtonControl())
       ->setLabel(pht('Provider'))
       ->setName('provider')
@@ -83,7 +79,7 @@ public function processRequest() {
 
     $form_box = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Add Authentication Provider'))
-      ->setFormError($errors)
+      ->setFormErrors($errors)
       ->setForm($form);
 
     $crumbs = $this->buildApplicationCrumbs();

src/applications/calendar/controller/PhabricatorCalendarEditStatusController.php

@@ -165,7 +165,7 @@ public function processRequest() {
 
     $form_box = id(new PHUIObjectBoxView())
       ->setHeaderText($page_title)
-      ->setFormError($error_view)
+      ->setFormErrors($errors)
       ->setForm($form);
 
     $nav = $this->buildSideNavView($status);

src/applications/conduit/controller/PhabricatorConduitConsoleController.php

@@ -112,7 +112,7 @@ public function processRequest() {
 
     $form_box = id(new PHUIObjectBoxView())
       ->setHeaderText($method->getAPIMethodName())
-      ->setFormError($status_view)
+      ->setErrorView($status_view)
       ->setForm($form);
 
     $crumbs = $this->buildApplicationCrumbs();

src/applications/config/controller/PhabricatorConfigEditController.php

@@ -195,9 +195,12 @@ public function processRequest() {
 
     $form_box = id(new PHUIObjectBoxView())
       ->setHeaderText($title)
-      ->setFormError($error_view)
       ->setForm($form);
 
+    if ($error_view) {
+       $form_box->setErrorView($error_view);
+    }
+
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->addTextCrumb(pht('Config'), $this->getApplicationURI());
 

src/applications/countdown/controller/PhabricatorCountdownEditController.php

@@ -35,7 +35,6 @@ public function processRequest() {
       $countdown = PhabricatorCountdown::initializeNewCountdown($user);
     }
 
-    $error_view = null;
     $e_text = true;
     $e_epoch = null;
 
@@ -71,11 +70,6 @@ public function processRequest() {
         $countdown->save();
         return id(new AphrontRedirectResponse())
           ->setURI('/countdown/'.$countdown->getID().'/');
-      } else {
-        $error_view = id(new AphrontErrorView())
-          ->setErrors($errors)
-          ->setTitle(pht('It\'s not The Final Countdown (du nu nuuu nun)' .
-            ' until you fix these problem'));
       }
     }
 
@@ -135,7 +129,7 @@ public function processRequest() {
 
     $form_box = id(new PHUIObjectBoxView())
       ->setHeaderText($page_title)
-      ->setFormError($error_view)
+      ->setFormErrors($errors)
       ->setForm($form);
 
     return $this->buildApplicationPage(

src/applications/differential/controller/DifferentialDiffCreateController.php

@@ -84,14 +84,8 @@ public function processRequest() {
 
     $form_box = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Create New Diff'))
-      ->setForm($form);
-
-    if ($errors) {
-      $error_view = id(new AphrontErrorView())
-        ->setSeverity(AphrontErrorView::SEVERITY_ERROR)
-        ->appendChild($errors);
-      $form_box->setFormError($error_view);
-    }
+      ->setForm($form)
+      ->setFormErrors($errors);
 
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->addTextCrumb(pht('Create Diff'));

src/applications/differential/controller/DifferentialRevisionEditController.php

@@ -108,13 +108,6 @@ public function processRequest() {
       $form->setAction('/differential/revision/edit/');
     }
 
-    $error_view = null;
-    if ($errors) {
-      $error_view = id(new AphrontErrorView())
-        ->setTitle(pht('Form Errors'))
-        ->setErrors($errors);
-    }
-
     if ($diff && $revision->getID()) {
       $form
         ->appendChild(
@@ -168,7 +161,7 @@ public function processRequest() {
 
     $form_box = id(new PHUIObjectBoxView())
       ->setHeaderText($title)
-      ->setFormError($error_view)
+      ->setFormErrors($errors)
       ->setForm($form);
 
     $crumbs->addTextCrumb($title);