Split paste create/edit and list views

Summary:
We have this hybrid "create / last few pastes" landing screen right now but I ~never use the list at the bottom and it makes the controller kind of complicated. I want to let you edit pastes too, and this generally simplifies things.

Also makes the textarea monospaced and cleans up the fork logic a bit.

Test Plan: Created, forked pastes. Viewed paste lists. Viewed pastes.

Reviewers: vrana, btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1690

Differential Revision: https://secure.phabricator.com/D3375

Author: epriestley

conf/default.conf.php

@@ -1196,7 +1196,6 @@
     'erb' => 'Embedded Ruby/ERB',
     'erlang' => 'Erlang',
     'html' => 'HTML',
-    'infer' => 'Infer from title (extension)',
     'java' => 'Java',
     'js' => 'Javascript',
     'mysql' => 'MySQL',
@@ -1210,8 +1209,6 @@
     'xml' => 'XML',
   ),
 
-  'pygments.dropdown-default' => 'infer',
-
   // This is an override list of regular expressions which allows you to choose
   // what language files are highlighted as. If your projects have certain rules
   // about filenames or use unusual or ambiguous language extensions, you can

src/__phutil_library_map__.php

@@ -892,6 +892,7 @@
     'PhabricatorPaste' => 'applications/paste/storage/PhabricatorPaste.php',
     'PhabricatorPasteController' => 'applications/paste/controller/PhabricatorPasteController.php',
     'PhabricatorPasteDAO' => 'applications/paste/storage/PhabricatorPasteDAO.php',
+    'PhabricatorPasteEditController' => 'applications/paste/controller/PhabricatorPasteEditController.php',
     'PhabricatorPasteListController' => 'applications/paste/controller/PhabricatorPasteListController.php',
     'PhabricatorPasteQuery' => 'applications/paste/query/PhabricatorPasteQuery.php',
     'PhabricatorPasteViewController' => 'applications/paste/controller/PhabricatorPasteViewController.php',
@@ -1992,6 +1993,7 @@
     ),
     'PhabricatorPasteController' => 'PhabricatorController',
     'PhabricatorPasteDAO' => 'PhabricatorLiskDAO',
+    'PhabricatorPasteEditController' => 'PhabricatorPasteController',
     'PhabricatorPasteListController' => 'PhabricatorPasteController',
     'PhabricatorPasteQuery' => 'PhabricatorCursorPagedPolicyQuery',
     'PhabricatorPasteViewController' => 'PhabricatorPasteController',

src/applications/paste/application/PhabricatorApplicationPaste.php

@@ -34,7 +34,7 @@ public function getRoutes() {
     return array(
       '/P(?P<id>\d+)' => 'PhabricatorPasteViewController',
       '/paste/' => array(
-        '' => 'PhabricatorPasteListController',
+        '' => 'PhabricatorPasteEditController',
         'filter/(?P<filter>\w+)/' => 'PhabricatorPasteListController',
       ),
     );

src/applications/paste/controller/PhabricatorPasteController.php

@@ -28,7 +28,7 @@ public function buildSideNavView(PhabricatorPaste $paste = null) {
     }
 
     $nav->addLabel('Create');
-    $nav->addFilter('create', 'New Paste');
+    $nav->addFilter('edit', 'New Paste', $this->getApplicationURI());
 
     $nav->addSpacer();
     $nav->addLabel('Pastes');

src/applications/paste/controller/PhabricatorPasteEditController.php

@@ -0,0 +1,154 @@
+<?php
+
+/*
+ * Copyright 2012 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+final class PhabricatorPasteEditController extends PhabricatorPasteController {
+
+  public function processRequest() {
+    $request = $this->getRequest();
+    $user = $request->getUser();
+
+    $paste = new PhabricatorPaste();
+    $title = 'Create Paste';
+
+    $parent_id = $request->getStr('parent');
+    $parent = null;
+    if ($parent_id) {
+      // NOTE: If the Paste is forked from a paste which the user no longer
+      // has permission to see, we still let them edit it.
+      $parent = id(new PhabricatorPasteQuery())
+        ->setViewer($user)
+        ->withIDs(array($parent_id))
+        ->execute();
+      $parent = head($parent);
+
+      if ($parent) {
+        $paste->setParentPHID($parent->getPHID());
+      }
+    }
+
+    $text = null;
+    $e_text = true;
+    $errors = array();
+    if ($request->isFormPost()) {
+      $text = $request->getStr('text');
+      if (!strlen($text)) {
+        $e_text = 'Required';
+        $errors[] = 'The paste may not be blank.';
+      } else {
+        $e_text = null;
+      }
+
+      $paste->setTitle($request->getStr('title'));
+      $paste->setLanguage($request->getStr('language'));
+
+      if (!$errors) {
+        $paste_file = PhabricatorFile::newFromFileData(
+          $text,
+          array(
+            'name' => $title,
+            'mime-type' => 'text/plain; charset=utf-8',
+            'authorPHID' => $user->getPHID(),
+          ));
+        $paste->setFilePHID($paste_file->getPHID());
+        $paste->setAuthorPHID($user->getPHID());
+        $paste->save();
+
+        return id(new AphrontRedirectResponse())->setURI($paste->getURI());
+      }
+    } else {
+      if ($parent) {
+        $paste->setTitle('Fork of '.$parent->getFullName());
+        $paste->setLanguage($parent->getLanguage());
+
+        $parent_file = id(new PhabricatorFile())->loadOneWhere(
+          'phid = %s',
+          $parent->getFilePHID());
+        $text = $parent_file->loadFileData();
+      }
+    }
+
+    $error_view = null;
+    if ($errors) {
+      $error_view = id(new AphrontErrorView())
+        ->setTitle('A fatal omission!')
+        ->setErrors($errors);
+    }
+
+    $form = new AphrontFormView();
+    $form->setFlexible(true);
+
+    $langs = array(
+      '' => '(Detect With Wizardly Powers)',
+    ) + PhabricatorEnv::getEnvConfig('pygments.dropdown-choices');
+
+    $submit = id(new AphrontFormSubmitControl())
+      ->setValue('Create Paste');
+
+    $form
+      ->setUser($user)
+      ->addHiddenInput('parent', $parent_id)
+      ->appendChild(
+        id(new AphrontFormTextControl())
+          ->setLabel('Title')
+          ->setValue($paste->getTitle())
+          ->setName('title'))
+      ->appendChild(
+        id(new AphrontFormSelectControl())
+          ->setLabel('Language')
+          ->setName('language')
+          ->setValue($paste->getLanguage())
+          ->setOptions($langs))
+      ->appendChild(
+        id(new AphrontFormTextAreaControl())
+          ->setLabel('Text')
+          ->setError($e_text)
+          ->setValue($text)
+          ->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_TALL)
+          ->setCustomClass('PhabricatorMonospaced')
+          ->setName('text'))
+
+    /* TODO: Doesn't have any useful options yet.
+      ->appendChild(
+        id(new AphrontFormPolicyControl())
+          ->setLabel('Visible To')
+          ->setUser($user)
+          ->setValue(
+            $new_paste->getPolicy(PhabricatorPolicyCapability::CAN_VIEW))
+          ->setName('policy'))
+    */
+
+      ->appendChild($submit);
+
+    $nav = $this->buildSideNavView();
+    $nav->selectFilter('edit');
+    $nav->appendChild(
+      array(
+        id(new PhabricatorHeaderView())->setHeader('Create Paste'),
+        $error_view,
+        $form,
+      ));
+
+    return $this->buildApplicationPage(
+      $nav,
+      array(
+        'title' => $title,
+        'device' => true,
+      ));
+  }
+
+}