configure: append -Werror to CFLAGS (don't prepend)#1523
Merged
bapt merged 2 commits intofreebsd:masterfrom Jan 2, 2017
Merged
configure: append -Werror to CFLAGS (don't prepend)#1523bapt merged 2 commits intofreebsd:masterfrom
bapt merged 2 commits intofreebsd:masterfrom
Conversation
Previously if CFLAGS contained -Wno-error that would override the -Werror required for this configure test to work correctly. Issue freebsd#1522
ac_cv_func_basename and ac_cv_func_dirname may already have cached true values, beceause these functions do in fact exist. However, the test here is for the old-style BSD implementation, so we don't want to accept a cached result of mere existence. Issue freebsd#1522
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if CFLAGS contained -Wno-error that would override the
-Werror required for this configure test to work correctly.
Issue #1522