pkg-query: support evaluation of complex attributes (lists) #2591
+147
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for querying complex attributes (lists) in the evaluation string mechanism. This includes: - %d[nov]: Dependencies (Name, Origin, Version) - %r[nov]: Reverse dependencies (Name, Origin, Version) - %C: Categories - %L: Licenses - %B: Shared libraries required - %b: Shared libraries provided - %A[tv]: Annotations (Tag, Value) These are implemented by generating subqueries using EXISTS/NOT EXISTS operators in the resulting SQL. The following fields are not implemented as their use cases are unclear: - %F[psugmftl]: the list of files - %S[pugmf]: the list of (sub-)directories - %O[kvdD]: the list of options - %U: the list of users needed - %G: the list of groups needed
Add regression tests to verify the behavior of evaluating dependency attributes (%dn) in query expressions. - Test exact match (=) - Test inequality (!=)
Update pkg-query(8) to include documentation for the newly supported multiline variables in evaluation expressions. - Split variables into 'Normal Variables' and 'Multiline variables' - Add description and example for multiline variable evaluation (e.g., %dn) - List supported multiline variables: %d, %r, %C, %L, %B, %b, %A
Member
|
it does not help me burry the sql deep down in the libpkg, but it is a nice feature ! thank you I'll review ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for evaluating complex attributes (multiline variables like dependencies, categories, etc.) within the
pkg query -eevaluation strings.Previously, it was not possible to filter packages based on list-type attributes directly in the query evaluation. This change allows users to perform queries such as finding packages that depend on a specific library or belong to a certain category.
Changes
EXISTS/NOT EXISTSoperators to support list attributes.=and!=).Supported Attributes
The following attributes are now supported in evaluation strings:
%d[nov]: Dependencies (Name, Origin, Version)%r[nov]: Reverse dependencies (Name, Origin, Version)%C: Categories%L: Licenses%B: Required shared libraries%b: Provided shared libraries%A[tv]: Annotations (Tag, Value)Example Usage
List packages that depend on
python312:pkg query -e '%dn = "python312"' %o
List packages that do not depend on
curl:pkg query -e '%dn != "curl"' %o
Note
The following attributes were intentionally omitted as their use cases in evaluation strings are unclear:
%F)%S,%D)%O)%U,%G)