Remove deprecated GenericArray::from_slice usage

[iduartgomez]

Description

The codebase currently has multiple instances of GenericArray::from_slice which is deprecated. These usages are currently suppressed with #[allow(deprecated)] attributes.

Affected Files

1. crates/core/src/transport/packet_data.rs

   • Line 85, 87, 278, 300
   • Module-level #[allow(deprecated)] at line 4
   • Function-level attributes at lines 77, 152, 277, 299

2. crates/core/src/contract/executor/runtime.rs

   • Lines 379, 381, 669, 671
   • Block-level #[allow(deprecated)] at lines 374, 664

3. crates/core/src/config/secret.rs

   • Line 160
   • Module-level and impl-level #[allow(deprecated)] at lines 3, 151

4. apps/freenet-email-app/web/src/inbox.rs

   • Lines 217, 219

Task

Replace all deprecated GenericArray::from_slice calls with the recommended alternative (likely using Array::from_slice or similar from the hybrid-array crate or the newer API).

Acceptance Criteria

• All GenericArray::from_slice usages replaced with non-deprecated alternative
• All #[allow(deprecated)] attributes related to GenericArray removed
• Code compiles without deprecation warnings
• All tests pass

[github-actions]

🤖 Auto-labeled

Applied labels:

• T-enhancement (95% confidence)
• E-medium (80% confidence)
• A-crypto (90% confidence)
• A-developer-xp (80% confidence)
• A-contracts (75% confidence)

Reasoning: The report requests replacing deprecated GenericArray::from_slice usages across several crates — this is a code-quality / modernization improvement rather than a bug or new feature, so T-enhancement is appropriate. The change touches crypto-related types (GenericArray is commonly used with cryptographic primitives) and the contract runtime plus other crates, so A-crypto and A-contracts are relevant; it also improves developer experience by removing deprecated APIs and allow attributes (A-developer-xp). Because multiple files across crates must be updated and tests verified, the effort is estimated E-medium (not trivial but well-scoped). Confidences reflect the clarity of the report and typical usage of GenericArray.

Previous labels: none

If these labels are incorrect, please update them. This helps improve the auto-labeling system.