Fix peer recommendation to use full skip_connections set #1906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem When handling FindOptimalPeer requests, the gateway was only skipping the joiner peer when recommending connections: HashSet::from([joiner.peer.clone()]) This caused the gateway to recommend itself or peers that the joiner was already connected to, preventing proper peer-to-peer mesh formation in small networks. ## Fix Use the full skip_connections set that includes all peers the joiner is already connected to: skip_connections.iter().cloned().collect() This ensures the gateway only recommends NEW peers that the joiner isn't already connected to. ## Background This fix was originally implemented in commit 24a6b7c (branch fix/connection-maintenance-skip-list) but was never merged to main. This represents a regression that prevented small network mesh formation. ## Testing - All existing connectivity tests pass - Fix enables proper peer discovery in multi-peer networks Related: #1905, #1904, #1889 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
iduartgomez
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When handling
FindOptimalPeerrequests in small networks, the gateway was only skipping the joiner peer when recommending connections:This caused the gateway to repeatedly recommend itself or peers that the joiner was already connected to, preventing proper peer-to-peer mesh formation.
Example failure scenario:
FindOptimalPeerto GatewaySolution
Use the full
skip_connectionsset that includes all peers the joiner is already connected to:Location:
crates/core/src/operations/connect.rs:199This ensures the gateway only recommends NEW peers that the joiner isn't already connected to.
Background
This fix was originally implemented in commit 24a6b7c (branch
fix/connection-maintenance-skip-list) but was never merged to main. This PR reapplies that critical fix.Testing
✅ All existing connectivity tests pass:
test_gateway_reconnectiontest_basic_gateway_connectivityThe fix enables proper peer discovery in multi-peer networks by ensuring gateways provide useful peer recommendations.
Related Issues
🤖 Generated with Claude Code
[AI-assisted debugging and comment]