Skip to content

Fix peer recommendation to use full skip_connections set #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
Merged

Fix peer recommendation to use full skip_connections set #1906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/core/src/operations/connect.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,11 @@ impl Operation for ConnectOp {
skip_forwards = ?skip_forwards,
"Got queried for new connections from joiner",
);
// Use the full skip_connections set to avoid recommending peers
// that the joiner is already connected to (including the gateway itself)
if let Some(desirable_peer) = op_manager.ring.closest_to_location(
*ideal_location,
HashSet::from([joiner.peer.clone()]),
skip_connections.iter().cloned().collect(),
) {
tracing::debug!(
tx = %id,
Expand Down
Loading