fix: keep listener ports out of Windows exclusion range #2083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses clippy::manual_find lint by replacing the explicit for loop with the idiomatic .find() method. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
sanity
added a commit
that referenced
this pull request
Nov 17, 2025
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary\n- detect Windows/WSL installs and prefer known-safe high UDP port ranges (still allowing 31337) before falling back to OS-assigned ephemerals so the default listener no longer lands inside Windows' excluded bands\n- add lightweight WSL detection helpers, range randomization, and a regression test that ensures the selector only returns values in the curated ranges\n\nFixes #2058\n\n## Testing\n- cargo test --lib config::port_allocation\n- cargo clippy --all-targets --all-features