fix: advertise observed addresses for private joiners #2088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iduartgomez
reviewed
Nov 15, 2025
| extract_sender_from_message_mut(&mut peer_conn.msg) | ||
| { | ||
| if sender_mut.peer.addr.ip().is_unspecified() { | ||
| let sender_ip = new_peer_id.addr.ip(); |
Collaborator
There was a problem hiding this comment.
We shouldnt need to do this, if we need to do this then we must rethink this a bit. We shouldnt have a public IP until is given back by the gateway.
iduartgomez
reviewed
Nov 15, 2025
| bincode::deserialize(data).map_err(|err| ConnectionError::Serialization(Some(err))) | ||
| } | ||
|
|
||
| fn is_publicly_routable(ip: IpAddr) -> bool { |
Collaborator
There was a problem hiding this comment.
We shouldnt need to do this, seems like a hack.
iduartgomez
reviewed
Nov 15, 2025
| } | ||
| } | ||
|
|
||
| fn is_publicly_routable(ip: IpAddr) -> bool { |
Collaborator
Author
|
Closing in favor of a redesigned fix: we need to make the joiner address optional and fill it in at the gateway, not mutate sender metadata at the transport layer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing