Skip to content

fix: unblock local puts without downstream ack #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2025
Merged

fix: unblock local puts without downstream ack #2089

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5550cf2
fix: finalize local puts without downstream ack
sanity Nov 15, 2025
904d1e3
Merge branch 'main' into issue-2086
sanity Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 38 additions & 9 deletions crates/core/src/operations/put.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,15 +295,44 @@ impl Operation for PutOp {
htl: *htl,
});

// Transition to AwaitingResponse state to handle future SuccessfulPut messages
new_state = Some(PutState::AwaitingResponse {
key,
upstream: Some(prev_sender.clone()),
contract: contract.clone(),
state: modified_value,
subscribe,
origin: origin.clone(),
});
// When we're the origin node we already seeded the contract locally.
// Treat downstream SuccessfulPut messages as best-effort so River is unblocked.
Copy link
Collaborator

@iduartgomez iduartgomez Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

River is just one application, I dlnt think we need to mention it here

if origin.peer == own_location.peer {
tracing::debug!(
tx = %id,
%key,
"Origin node finishing PUT without waiting for SuccessfulPut ack"
);

if subscribe {
if !op_manager.failed_parents().contains(id) {
let child_tx =
super::start_subscription_request(op_manager, *id, key);
tracing::debug!(
tx = %id,
%child_tx,
"started subscription as child operation"
);
} else {
tracing::warn!(
tx = %id,
"not starting subscription for failed parent operation"
);
}
}

new_state = Some(PutState::Finished { key });
} else {
// Transition to AwaitingResponse state to handle future SuccessfulPut messages
new_state = Some(PutState::AwaitingResponse {
key,
upstream: Some(prev_sender.clone()),
contract: contract.clone(),
state: modified_value,
subscribe,
origin: origin.clone(),
});
}
} else {
// No other peers to forward to - we're the final destination
tracing::warn!(
Expand Down
Loading