Skip to content

Conversation

@sanity
Copy link
Collaborator

@sanity sanity commented Nov 17, 2025

Summary

  • on three-node connectivity timeout, log the last peer snapshots plus a brief event summary instead of failing silently
  • pull aggregated events and emit total count + the last 10 event kinds to make future flakes actionable

Testing

  • cargo test -p freenet test_three_node_network_connectivity -- --nocapture

@sanity sanity changed the title test: improve diagnostics for three-node connectivity test: Improve diagnostics for three-node connectivity Nov 17, 2025
@sanity sanity changed the title test: Improve diagnostics for three-node connectivity test: improve diagnostics for three-node connectivity Nov 17, 2025
@sanity sanity added this pull request to the merge queue Nov 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 17, 2025
@sanity sanity added this pull request to the merge queue Nov 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 17, 2025
@sanity sanity added this pull request to the merge queue Nov 17, 2025
Merged via the queue into main with commit fe1411d Nov 17, 2025
11 checks passed
@sanity sanity deleted the diagnostics-three-node-connectivity branch November 17, 2025 20:25
use tokio::time::timeout;
use tokio_tungstenite::connect_async;

async fn log_recent_events(ctx: &TestContext, label: &str) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a dump of all events in a file from the aggregator for debugging, we should include this in CI as an artifact somehow probably: #2076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants