revert: undo Joiner enum (#2158) to unblock PR stack #2167-#2175 #2181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #2158 ("fix: use Joiner enum to properly handle NAT peer address discovery")
Why
PR #2158 was merged to fix NAT peer address discovery, but it conflicts with the pending PR stack (#2167 → #2169 → #2171 → #2172 → #2174 → #2175) which takes a more comprehensive approach to the same problem.
The PR stack:
PeerAddrenum (Unknown/Known) - similar concept but integrated with broader refactoringSocketAddrdirectly instead of relying on embedded addressesfrom/senderfields from wire protocol messagesBy reverting #2158, the PR stack will merge cleanly and CI can run on those PRs. The PR stack's approach supersedes and improves upon #2158's
Joinerenum.Impact
Joinerenum fromconnect.rs[AI-assisted - Claude]