Skip to content

chore(mirror): bump reusable-workflow pin and switch to MATRIX_DEV_ROOM_ID#76

Merged
sanity merged 1 commit into
mainfrom
pr4-stdlib-mirror-bump
May 17, 2026
Merged

chore(mirror): bump reusable-workflow pin and switch to MATRIX_DEV_ROOM_ID#76
sanity merged 1 commit into
mainfrom
pr4-stdlib-mirror-bump

Conversation

@sanity
Copy link
Copy Markdown
Contributor

@sanity sanity commented May 17, 2026

Problem

This caller's mirror workflow is pinned to `freenet-git@a93179` (pre-#39) and passes `MATRIX_ROOM_ID` as the secret name. The reusable workflow at that pin still declared `MATRIX_ROOM_ID`, so it kept working, but:

  1. Stale workflow pin: a93179 predates several improvements (feat: logging in contract and non contract env #39 secret rename, chore: sync Rust ver with core; reduce deps #46 auto-detect snapshot/history rescue mode, feat: add blocking_subscribe field to PUT/GET contract requests #50 push refs/tags/* in history mode).
  2. Wrong secret name: `MATRIX_ROOM_ID` is slated to be re-pointed at `#freenet-locutus` (community channel) once all dev-facing callers move to `MATRIX_DEV_ROOM_ID`. Without renaming this caller first, the org-secret flip would silently re-route mirror failure alerts from the dev channel into the community channel.

Solution

Bump pin from `a93179` → `8f00293` (the merge SHA freenet-core's mirror workflow uses, for cross-repo consistency — the reusable workflow file content is identical between 8f00293 and current main as of 2026-05-16). Rename the secret pass-through from `MATRIX_ROOM_ID` → `MATRIX_DEV_ROOM_ID` to match the reusable workflow's declared input post-#39.

The reusable workflow's internal `cargo install freenet-git --locked` step still resolves to `latest`, so this caller picks up the freshly-published 0.1.22 (with the new fallback-failure error classification + Ian's #52 NotFound handling) on the next mirror run regardless of pin SHA. The pin only governs the YAML of the reusable workflow itself.

Testing

YAML-only change. Validation is observational on the next scheduled cron (12:53 UTC daily) or first push to main after merge.

Behavior

Today: no destination change. Both `MATRIX_ROOM_ID` and `MATRIX_DEV_ROOM_ID` happen to point at the same room (`#freenet-dev`'s room id), so failure alerts continue landing in `#freenet-dev`.

After the org-secret flip: `MATRIX_ROOM_ID` gets re-pointed at `#freenet-locutus` (matching its name). This PR is what makes that flip safe — without the rename, mirror failures would silently start announcing in the community channel.

Companion changes

Fixes

No GitHub issue filed — discovered while investigating recurring rescue-demos Matrix failure alerts for the freenet-stdlib mirror.

[AI-assisted - Claude]

…_ROOM_ID

freenet-git#39 renamed the declared Matrix-room secret in mirror-repo.yml
(MATRIX_ROOM_ID -> MATRIX_DEV_ROOM_ID) to route operational mirror/rescue
failures to the dev channel (#freenet-dev) rather than the user-facing
community channel (#freenet-locutus). This caller was still pinned to
a93179 (pre-rename) and passing the old secret name; it kept working
because the old name was still declared at that pin, but it bound the
mirror to a stale workflow and routed via a secret that's slated to be
re-pointed at #freenet-locutus once all dev-facing callers have moved
across.

Bump to 8f00293 (same SHA freenet-core's mirror workflow uses, for
cross-repo consistency) and rename the secret pass-through accordingly.
The mirror failure alerts now route via MATRIX_DEV_ROOM_ID explicitly,
matching the documented intent and freeing MATRIX_ROOM_ID to be
re-pointed at #freenet-locutus for genuine user-facing announcements.

No behavior change in this PR: today both MATRIX_ROOM_ID and
MATRIX_DEV_ROOM_ID point at #freenet-dev's room id, so failure alerts
continue to land in the same room. The semantic correction (and the
org-secret-value flip that follows) is what unlocks the eventual
community-channel routing.

[AI-assisted - Claude]
@sanity sanity merged commit 524a631 into main May 17, 2026
9 checks passed
@sanity sanity deleted the pr4-stdlib-mirror-bump branch May 17, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant