chore(mirror): bump reusable-workflow pin and switch to MATRIX_DEV_ROOM_ID#76
Merged
Conversation
…_ROOM_ID freenet-git#39 renamed the declared Matrix-room secret in mirror-repo.yml (MATRIX_ROOM_ID -> MATRIX_DEV_ROOM_ID) to route operational mirror/rescue failures to the dev channel (#freenet-dev) rather than the user-facing community channel (#freenet-locutus). This caller was still pinned to a93179 (pre-rename) and passing the old secret name; it kept working because the old name was still declared at that pin, but it bound the mirror to a stale workflow and routed via a secret that's slated to be re-pointed at #freenet-locutus once all dev-facing callers have moved across. Bump to 8f00293 (same SHA freenet-core's mirror workflow uses, for cross-repo consistency) and rename the secret pass-through accordingly. The mirror failure alerts now route via MATRIX_DEV_ROOM_ID explicitly, matching the documented intent and freeing MATRIX_ROOM_ID to be re-pointed at #freenet-locutus for genuine user-facing announcements. No behavior change in this PR: today both MATRIX_ROOM_ID and MATRIX_DEV_ROOM_ID point at #freenet-dev's room id, so failure alerts continue to land in the same room. The semantic correction (and the org-secret-value flip that follows) is what unlocks the eventual community-channel routing. [AI-assisted - Claude]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This caller's mirror workflow is pinned to `freenet-git@a93179` (pre-#39) and passes `MATRIX_ROOM_ID` as the secret name. The reusable workflow at that pin still declared `MATRIX_ROOM_ID`, so it kept working, but:
Solution
Bump pin from `a93179` → `8f00293` (the merge SHA freenet-core's mirror workflow uses, for cross-repo consistency — the reusable workflow file content is identical between 8f00293 and current main as of 2026-05-16). Rename the secret pass-through from `MATRIX_ROOM_ID` → `MATRIX_DEV_ROOM_ID` to match the reusable workflow's declared input post-#39.
The reusable workflow's internal `cargo install freenet-git --locked` step still resolves to `latest`, so this caller picks up the freshly-published 0.1.22 (with the new fallback-failure error classification + Ian's #52 NotFound handling) on the next mirror run regardless of pin SHA. The pin only governs the YAML of the reusable workflow itself.
Testing
YAML-only change. Validation is observational on the next scheduled cron (12:53 UTC daily) or first push to main after merge.
Behavior
Today: no destination change. Both `MATRIX_ROOM_ID` and `MATRIX_DEV_ROOM_ID` happen to point at the same room (`#freenet-dev`'s room id), so failure alerts continue landing in `#freenet-dev`.
After the org-secret flip: `MATRIX_ROOM_ID` gets re-pointed at `#freenet-locutus` (matching its name). This PR is what makes that flip safe — without the rename, mirror failures would silently start announcing in the community channel.
Companion changes
Fixes
No GitHub issue filed — discovered while investigating recurring rescue-demos Matrix failure alerts for the freenet-stdlib mirror.
[AI-assisted - Claude]