fix: stop lowercasing CodeHash::encode Base58 output#77
Merged
Conversation
The BITCOIN Base58 alphabet is case-sensitive, so lowercasing the encoded output corrupted any hash containing uppercase characters and broke the encode -> ContractKey::from_params roundtrip, which decodes with the same case-sensitive alphabet. This aligns CodeHash::encode with ContractInstanceId::encode, ContractKey::encoded_code_hash, and ContractCode::hash_str, which already preserve case. Fixes freenet/freenet-core#4214 https://claude.ai/code/session_01ViYSqfF3NwQBiaVkzkWET6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BITCOIN Base58 alphabet is case-sensitive, so lowercasing the
encoded output corrupted any hash containing uppercase characters and
broke the encode -> ContractKey::from_params roundtrip, which decodes
with the same case-sensitive alphabet. This aligns CodeHash::encode
with ContractInstanceId::encode, ContractKey::encoded_code_hash, and
ContractCode::hash_str, which already preserve case.
Fixes freenet/freenet-core#4214
https://claude.ai/code/session_01ViYSqfF3NwQBiaVkzkWET6