Skip to content

test(e2e): flip FREENET_LIVE_E2E_SEND off + fix click-to-read assertion (#81)#123

Merged
iduartgomez merged 1 commit intomainfrom
test/flip-live-e2e-send-gate-81
May 6, 2026
Merged

test(e2e): flip FREENET_LIVE_E2E_SEND off + fix click-to-read assertion (#81)#123
iduartgomez merged 1 commit intomainfrom
test/flip-live-e2e-send-gate-81

Conversation

@iduartgomez
Copy link
Copy Markdown
Contributor

Summary

#81 followup. With #114 (dedup) + #115 (kept_for) + #120 (UserId reuse) all merged, plus a spec correction here, the iso harness is deterministically green and the kill switch can come off.

Changes

  1. Spec fix: replace `page.goBack()` with `page.reload()` in test 3's click-to-read assertion. The SPA doesn't push history entries on message click, so `goBack` was navigating to about:blank rather than re-mounting the inbox. `reload` actually exercises the Click-to-read deletes message from inbox list (cross-node, kept_for rebuild miss) #113 target — kept-locally snapshot must survive the GetIdentities echo on a fresh page load.
  2. Drop FREENET_LIVE_E2E_SEND gate on tests 2 + 3.
  3. Re-gate two narrower assertions that are separate concerns:

Verification

3 consecutive iso runs all pass in ~12s each:
```
run 1: EXIT=0 3 passed (13.1s)
run 2: EXIT=0 3 passed (11.4s)
run 3: EXIT=0 3 passed (11.9s)
```

Test plan

  • spec parses (`npx playwright test --list`)
  • 3× green local runs
  • CI green

…on (#81)

#114 + #115 + #120 fixes plus a spec correction (use page.reload()
instead of page.goBack(), since the SPA doesn't push history entries
on click — goBack landed on about:blank rather than the inbox)
make tests 2 + 3 deterministically green on the iso harness. Drop
the FREENET_LIVE_E2E_SEND gate so they run by default.

Two assertions stay gated as separate concerns:

- Test 3 round 3 (alice → bob retry) gated on
  FREENET_LIVE_E2E_AFT_CAP_RAISED — AFT day-1 cap is 1 slot, alice
  burned hers in round 1; needs #85 to make tier configurable.
- Test 3 round 2 (bob → alice reply) gated on FREENET_LIVE_E2E_REPLY
  — flaky ~33%, separate flake tracked in #122. Click-to-read +
  reload assertion (the original #113 target) still runs and passes
  deterministically.

Verified locally via 3 consecutive `cargo make test-e2e-real-node`
runs, all passing in ~12s each.
@iduartgomez iduartgomez merged commit b990add into main May 6, 2026
4 of 6 checks passed
@iduartgomez iduartgomez deleted the test/flip-live-e2e-send-gate-81 branch May 6, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant