feat: add new textVerticalAlign prop to radio button#109
Merged
snapsnapturtle merged 3 commits intomainfrom Jun 9, 2021
Merged
feat: add new textVerticalAlign prop to radio button#109snapsnapturtle merged 3 commits intomainfrom
snapsnapturtle merged 3 commits intomainfrom
Conversation
snapsnapturtle
requested review from
LeonardKoch,
agonzalezUX,
duranmla,
lukahartwig,
nlopin and
rafael-sepeda
as code owners
nlopin
reviewed
Jun 8, 2021
nlopin
approved these changes
Jun 9, 2021
snapsnapturtle
deleted the
feature/allow-specifying-text-alignment-for-radio
branch
github-actions bot
pushed a commit
that referenced
this pull request
Jun 9, 2021
## [1.3.0](v1.2.2...v1.3.0) (2021-06-09) ### Features * add new textVerticalAlign prop to radio button ([#109](#109)) ([29a7c60](29a7c60))
Contributor
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Adding a complement to the
textVerticalAlignprop of the Checkbox to the RadioButton component.
Why:
In one of our tools, we have a design that has a multi line radio button label, with the radio button icon aligned at the top. In addition, this increases feature parity with the Checkbox component.
Media:
Checklist:
While working on the RadioButton component, I also updated the documentation page to follow our current standards.