feat: add new label variants and filled prop#125
Merged
Conversation
snapsnapturtle
requested review from
LeonardKoch,
agonzalezUX,
duranmla,
lukahartwig,
nlopin and
rafael-sepeda
as code owners
rafael-sepeda
approved these changes
Jun 23, 2021
|
Thanks! |
bluessista
reviewed
Jun 28, 2021
| expect(render(<Label variant="success" filled />).container.firstChild).toHaveStyle(` | ||
| color: ${Colors.WHITE}; | ||
| border-color: ${Colors.POSITIVE_GREEN_900}; | ||
| backgroundColor: ${Colors.POSITIVE_GREEN_900}; |
Contributor
There was a problem hiding this comment.
This should be background-color.
Contributor
Author
There was a problem hiding this comment.
Sorry that it's in a different PR :( #138
github-actions bot
pushed a commit
that referenced
this pull request
Jun 28, 2021
## [1.7.0](v1.6.0...v1.7.0) (2021-06-28) ### Features * add new label variants and filled prop ([#125](#125)) ([f28c797](f28c797))
Contributor
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Adding new label color "info" and "warning" in addition to the ability to give all labels a more prominent style with the "filled" prop. Closes #2 .
Why:
Some of the recent designs include additional label styles that are used in tables across our tools. Currently they are Label components with custom styles. To provide a common and reusable pattern, we want to include these styles in the library.
Media:
Checklist:
Other:
This will change the styling of the variant "info" from grey to blue, while introducing a new variant (default) to replace the grey styles. The change can lead to unexpected colours of the label when the variant is explicitly specified. It will not cause any issue when no variant is specified, as the default looks identical.