fix: fixing the tooltip styles #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanFnz
approved these changes
May 9, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 9, 2025
### [2.31.2](v2.31.1...v2.31.2) (2025-05-09) ### Bug Fixes * fixing the tooltip styles ([#534](#534)) ([40ab351](40ab351))
Contributor
|
🎉 This PR is included in version 2.31.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In this PR, we are fixing the styling of the experimental
TooltipcomponentMedia
Why
The current implementation of the
Tooltip, that relies oncssfails, sincecssfiles are not bundled bytsc(and does not seem to be changing in the future)As a result, the
cssfile has to be manually included after the bundling, or an alternative approach needs to be followed.This PR fixes this issue by relying on the
createGlobalStyleAPI fromstyled-components
How
createGlobalStyleto replace the css usageTooltipStylescomponent in the DOMcssfile and it's import