Utilize “no operation” types for logging and metrics.#29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Within
unit.go, there were several methods onunitresponsible for checking to see if a logger or metric scope was provided during instantiation prior to utilization. Equipped with the knowledge that bothzapandtallyoffer “no operation” types, the code can be simplified so that these methods are no longer necessary.Tackles #29 .
Rationale
The code becomes cleaner and is easier to maintain without these unnecessary methods. It also fully leverages capabilities of both the
zapandtallypublic APIs.Suggested Versions
v2.1.1v3.1.0Example Usage
There are no API changes to
workas a result of this change - it is purely internal.