Fix nc not resetting when server issues new nonce without stale=true.#316
Merged
Conversation
morbit85
force-pushed
the
dmitry/fix_nc_reset
branch
from
c66ce91 to
c697a78
Compare
mjerris
approved these changes
May 4, 2026
When a server challenged with a new nonce but omitted stale=true, the nonce count (nc) carried over from the previous nonce instead of resetting to 1. Detect nonce changes by comparing the new nonce against the stored one, and regenerate cnonce/reset nc accordingly.
andywolk
force-pushed
the
dmitry/fix_nc_reset
branch
from
c697a78 to
25deac1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a server challenged with a new nonce but omitted stale=true, the nonce count (nc) carried over from the previous nonce instead of resetting to 1. Detect nonce changes by comparing the new nonce against the stored one, and regenerate cnonce/reset nc accordingly.