-
Notifications
You must be signed in to change notification settings - Fork 1
fix: add lowercase repository name output for Docker image tagging #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe GitHub Actions workflow was updated to output a lowercase version of the repository name and to use this lowercase value for Docker image tagging. The Docker build-and-push steps now consistently reference the lowercase repository name for image tags. No other logic or public entity declarations were changed. Changes
Suggested labels
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/docker-release.yml (1)
57-57: Prefer bash parameter-expansion over spawning a subshell
tr+ subshell is unnecessary and slower. Bash ≥ 4 (the default on Ubuntu runners) supports lowercase conversion natively:-echo "repo_lowercase=$(echo '${{ github.repository }}' | tr '[:upper:]' '[:lower:]')" >> $GITHUB_OUTPUT +echo "repo_lowercase=${GITHUB_REPOSITORY,,}" >> "$GITHUB_OUTPUT"Benefits: fewer processes, simpler quoting, and no risk of accidentally retaining single quotes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/docker-release.yml(2 hunks)
🔇 Additional comments (1)
.github/workflows/docker-release.yml (1)
74-75: Echo step still references the mixed-case repo – verify consistencyYou correctly switched the
tags:lines torepo_lowercase, but the later “Image digest” step (80-82) still echoes
ghcr.io/${{ github.repository }}.
If the registry entry is now entirely lowercase, that log line will point to a tag that was never pushed.Either:
- Update the echo to use
steps.vars.outputs.repo_lowercase, or- Keep both variants pushed to GHCR.
Please double-check which behaviour you want.
Summary by CodeRabbit