Merged
Conversation
Contributor
preetamfrejun
commented
Nov 19, 2025
preetamfrejun
commented
- Added Android Manifest permissions for RECORD_AUDIO and INTERNET
- Implemented runtime permission request in App.js to prevent crashes
- Added WebRTC registerGlobals() polyfill for sip.js compatibility
- Fixed UserAgent.makeCall to properly await the SIP invitation
- Resolved race condition in Softphone initialization hook
Irfan-wani
requested changes
Nov 22, 2025
| // this.endCurrentSession(); | ||
|
|
||
| if(!this.#userAgent){ | ||
| throw new Exceptions.UnknownException('Softphone.#handleEdgeDomainChange', 'UserAgent is not initialized'); |
Collaborator
There was a problem hiding this comment.
no need to check if useragent is present when changing edge domain as useragent will be re-registered anyways.
| }; | ||
|
|
||
| if(!this.#userAgent){ | ||
| this.#userAgent = new UserAgent(config); |
Collaborator
There was a problem hiding this comment.
no need to have this if condition as you are explicitly setting useragent to null before it.
| throw new Exceptions.UnknownException('Softphone.makeCall', JSON.stringify(responseData.message || '')); | ||
| } | ||
|
|
||
| console.log('Update primary virtual number successful.'); |
Collaborator
There was a problem hiding this comment.
move the console log under 200 block
Irfan-wani
approved these changes
Dec 4, 2025
Mansi-frejun
reviewed
Dec 4, 2025
| import { jwtDecode } from 'jwt-decode'; | ||
| import libphonenumber from "google-libphonenumber"; | ||
|
|
||
| export const isTokenValid = (token: string) => { |
Contributor
There was a problem hiding this comment.
Would it be better if we return a structured status object here instead of mixing booleans and strings? Something like - { valid: true } or { valid: false, reason: 'EXPIRED' | 'INVALID' })
(better for type check)
| #virtualNumbers: VirtualNumber[] = []; | ||
| #primaryVirtualNumber: string | null = null; | ||
|
|
||
| public constructor(tokenData?: TokenData) { |
Contributor
There was a problem hiding this comment.
public can be removed as constructor is by default public
Mansi-frejun
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.