Skip to content

Use orjson for request serialization to preserve unicode#2038

Merged
frenck merged 1 commit intomainfrom
frenck-2026-0369
Apr 16, 2026
Merged

Use orjson for request serialization to preserve unicode#2038
frenck merged 1 commit intomainfrom
frenck-2026-0369

Conversation

@frenck
Copy link
Copy Markdown
Owner

@frenck frenck commented Apr 16, 2026

Proposed Changes

Replace aiohttp's built-in json= parameter with orjson.dumps() for outgoing requests. aiohttp uses stdlib json.dumps which escapes non-ASCII characters to \uXXXX sequences, causing segment names with characters like éçà to be stored as escape sequences on the device. orjson (already a dependency) serializes to proper UTF-8 by default.

Related Issues

Fixes #1683

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Apr 16, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 16, 2026

Warning

Rate limit exceeded

@frenck has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 23 minutes and 33 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 23 minutes and 33 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9b799607-fced-4820-b112-473276a0e23b

📥 Commits

Reviewing files that changed from the base of the PR and between 38df3a8 and aa3879c.

📒 Files selected for processing (1)
  • src/wled/wled.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch frenck-2026-0369

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@frenck frenck merged commit cc3dea8 into main Apr 16, 2026
30 checks passed
@frenck frenck deleted the frenck-2026-0369 branch April 16, 2026 17:09
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue to update segment name with extended char like 'éçà'

1 participant