Add handling of live override mode#298
Merged
frenck merged 4 commits intofrenck:mainfrom Jun 12, 2021
drinfernoo:lor
Merged
Conversation
Contributor
Author
|
Hmm, why did this fail? 🤔 |
Contributor
Author
|
Am I passing the wrong responses to the test framework? They looked right to me... |
frenck
reviewed
Jun 8, 2021
Owner
|
There is nothing to review for me at this point, as the CI is failing. Please make sure the CI is passed before requesting reviews. |
Contributor
Author
|
My bad, I'm at a loss for why those tests are failing 😕 |
Codecov Report
@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 66.57% 67.12% +0.55%
==========================================
Files 4 4
Lines 356 365 +9
Branches 70 70
==========================================
+ Hits 237 245 +8
- Misses 108 109 +1
Partials 11 11
Continue to review full report at Codecov.
|
Contributor
Author
|
Hey! That's... better 😅 |
Contributor
Author
|
I don't appear to be able to add a label, but everything else is passing here 👍 |
Contributor
Author
|
🎉🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
loras a field in the device state, as it is only applicable to the entire device, and not to each individual segment.