Add Nightlight mode, extract deprecated nightlight fade from mode#315
Merged
Add Nightlight mode, extract deprecated nightlight fade from mode#315
Conversation
Codecov Report
@@ Coverage Diff @@
## main #315 +/- ##
==========================================
+ Coverage 67.03% 67.28% +0.25%
==========================================
Files 4 4
Lines 364 376 +12
Branches 70 72 +2
==========================================
+ Hits 244 253 +9
- Misses 109 110 +1
- Partials 11 13 +2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The Nightlight
fadeproperty has been deprecated and will be removed from WLED 0.13.Additionally, Nightlight
modewas introduced replacingfade.This PR implements the new
modeproperty and re-implements thefadeproperty by getting it frommodein case it isn't present in the API (and vice versa for backward compatibility).