Skip to content

Fix support for older WLED presets#336

Merged
frenck merged 1 commit intomainfrom
frenck-2021-1922
Jul 1, 2021
Merged

Fix support for older WLED presets#336
frenck merged 1 commit intomainfrom
frenck-2021-1922

Conversation

@frenck
Copy link
Copy Markdown
Owner

@frenck frenck commented Jul 1, 2021

Proposed Changes

If a WLED preset was created on an older version of WLED but carries along with the upgrades, it would end up having an older format.

In that case, the package would crash. This PR fixes that, by making a small adjustment to the format to support both the old and new styles.

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Jul 1, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 1, 2021

Codecov Report

Merging #336 (09756fc) into main (673a256) will decrease coverage by 0.47%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   65.70%   65.22%   -0.48%     
==========================================
  Files           4        4              
  Lines         414      417       +3     
  Branches       84       85       +1     
==========================================
  Hits          272      272              
- Misses        126      129       +3     
  Partials       16       16              
Impacted Files Coverage Δ
src/wled/models.py 76.32% <0.00%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 673a256...09756fc. Read the comment docs.

@frenck frenck merged commit 96b4820 into main Jul 1, 2021
@frenck frenck deleted the frenck-2021-1922 branch July 1, 2021 21:09
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant