Skip to content

Gracefully handle missing preset name#356

Merged
frenck merged 1 commit intomainfrom
frenck-2021-2042
Jul 22, 2021
Merged

Gracefully handle missing preset name#356
frenck merged 1 commit intomainfrom
frenck-2021-2042

Conversation

@frenck
Copy link
Copy Markdown
Owner

@frenck frenck commented Jul 22, 2021

Proposed Changes

Fixes a possible/reported case where preset has no name.

See: home-assistant/core#52762

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Jul 22, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 22, 2021

Codecov Report

Merging #356 (29799e5) into main (7550c6d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   65.22%   65.22%           
=======================================
  Files           4        4           
  Lines         417      417           
  Branches       85       85           
=======================================
  Hits          272      272           
  Misses        129      129           
  Partials       16       16           
Impacted Files Coverage Δ
src/wled/models.py 76.32% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7550c6d...29799e5. Read the comment docs.

@frenck frenck merged commit b33aa29 into main Jul 22, 2021
@frenck frenck deleted the frenck-2021-2042 branch July 22, 2021 13:08
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant