Skip to content

Replace packaging version tools with AwesomeVersion#464

Merged
frenck merged 1 commit intomainfrom
frenck-2021-3001
Nov 13, 2021
Merged

Replace packaging version tools with AwesomeVersion#464
frenck merged 1 commit intomainfrom
frenck-2021-3001

Conversation

@frenck
Copy link
Copy Markdown
Owner

@frenck frenck commented Nov 13, 2021

Proposed Changes

ref: home-assistant/core#59244

I could have solved it differently, but I have some more plans that would benefit from having AwesomeVersion available.

@frenck frenck added enhancement Enhancement of the code, not introducing new features. bugfix Inconsistencies or issues which will cause a problem for users or implementers. labels Nov 13, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 13, 2021

Codecov Report

Merging #464 (429f848) into main (f36d870) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   64.06%   64.14%   +0.07%     
==========================================
  Files           4        4              
  Lines         462      463       +1     
  Branches       98       98              
==========================================
+ Hits          296      297       +1     
  Misses        149      149              
  Partials       17       17              
Impacted Files Coverage Δ
src/wled/wled.py 50.73% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f36d870...429f848. Read the comment docs.

@frenck frenck merged commit 8568d1f into main Nov 13, 2021
@frenck frenck deleted the frenck-2021-3001 branch November 13, 2021 19:20
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementers. enhancement Enhancement of the code, not introducing new features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant