Merged
Conversation
Function names have not been changed
dopatraman
changed the title
dopatraman
requested review from
aramikm,
enddynayn,
johnmela,
mehtaishita,
saraswatpuneet,
shannonwells and
wilwade
and removed request for
aramikm
aramikm
approved these changes
Jun 30, 2022
saraswatpuneet
previously requested changes
Jun 30, 2022
Collaborator
saraswatpuneet
left a comment
saraswatpuneet
left a comment
There was a problem hiding this comment.
Just leaving this blocker for @wilwade to confirm if design docs should mention "Frequency chain" instead of only frequency for a better readability
wilwade
approved these changes
Jun 30, 2022
Collaborator
Good question. We went back and forth on this when talking about the chain name. We landed on just "Frequency". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to replace occurrences of "MRC" with "Frequency" so our documentation stays up to date with current naming.
Closes #211
Checklist