Fix: check_handle should apply the whitespace trimming and collapsing#2363
Merged
Fix: check_handle should apply the whitespace trimming and collapsing#2363
Conversation
wilwade
requested review from
a team,
JoeCap08055,
aramikm,
claireclark1,
enddynayn,
mattheworris and
shannonwells
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
github-actions
bot
added
the
metadata-changed
github-actions
bot
removed
the
metadata-changed
2 tasks
github-actions
bot
added
the
metadata-changed
aramikm
approved these changes
Apr 28, 2025
Collaborator
aramikm
left a comment
aramikm
left a comment
There was a problem hiding this comment.
Looks good! I'm just surprised that we are not using the same functions to do the same checks or transformations in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to update the check_handle Runtime RPC to correctly use the whitespace trim and collapse
Closes #2362
Discussion
Checklist