Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| // not used yet | ||
| pub struct TestRewardsProvider {} |
| /// Storage for keeping a ledger of staked token amounts for accounts. | ||
| /// - Keys: AccountId | ||
| /// - Value: [`StakingDetails`](types::StakingDetails) | ||
| /// - Value: [`StakingDetails`] |
There was a problem hiding this comment.
updated due to 1.90 required linting guidelines
JoeCap08055
left a comment
There was a problem hiding this comment.
Looks great--one comment:
In the past, we've explicitly mirrored the SchemaIds from Mainnet onto Testnet by setting storage directly; then we set the max_schema_id on Testnet to 16000 so that any new schemas created won't interfere with the numeric ID space mirrored from Mainnet.
Do we want to continue this practice?
Or--since that practice was conceived before we had name resolution on-chain--do we no longer need it? Is there any advantage any longer to maintaining numeric ID parity between Testnet and Mainnet?
I think for now we can just create it as is using the script as is but after the release on mainnet and creation of those schemas on mainnet and getting their actual ids. We can always modify the testnet to reflect the mainnet in case we feel it's necessary. But I think having different ids should be fine since we usually handle it based on the environment. |
Goal
The goal of this PR is
Related to #https://github.com/ProjectLibertyLabs/interoperable-context-service/issues/42
Discussion
Example run
Checklist