Skip to content

added ics schemas to genesis#2662

Merged
aramikm merged 10 commits intomainfrom
ics_schemas
Jan 9, 2026
Merged

added ics schemas to genesis#2662
aramikm merged 10 commits intomainfrom
ics_schemas

Conversation

@aramikm
Copy link
Collaborator

@aramikm aramikm commented Jan 6, 2026

Goal

The goal of this PR is

Related to #https://github.com/ProjectLibertyLabs/interoperable-context-service/issues/42

Discussion

  • updated the rust version to 1.90
  • Added genesis for ics local dev nodes
  • Added a tool to upload ics schemas to paseo and mainnet

Example run

SUCCESS: ics.context-group-acl intent created with id of 16002
SUCCESS: ics.context-group-metadata intent created with id of 16003
SUCCESS: ics.public-key-key-agreement intent created with id of 16001
Map(3) {
  'ics.public-key-key-agreement' => 16001,
  'ics.context-group-acl' => 16002,
  'ics.context-group-metadata' => 16003
}
intentId 16001
intentId 16002
intentId 16003
schemaId = 16001
schemaId = 16002
schemaId = 16003

Checklist

  • Spec version incremented?

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
pallets/capacity/src/lib.rs 95.39% <ø> (+6.79%) ⬆️
pallets/messages/src/migration/v3.rs 93.02% <100.00%> (ø)
pallets/msa/src/lib.rs 96.37% <ø> (+3.97%) ⬆️
pallets/msa/src/offchain_storage.rs 83.83% <100.00%> (+5.64%) ⬆️
pallets/stateful-storage/src/migration/v2.rs 92.44% <100.00%> (ø)
pallets/stateful-storage/src/types.rs 81.99% <100.00%> (+3.32%) ⬆️

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jan 6, 2026
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jan 6, 2026
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jan 7, 2026
@aramikm aramikm marked this pull request as ready for review January 7, 2026 23:43
@aramikm aramikm requested a review from shannonwells as a code owner January 7, 2026 23:43
}

// not used yet
pub struct TestRewardsProvider {}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used

/// Storage for keeping a ledger of staked token amounts for accounts.
/// - Keys: AccountId
/// - Value: [`StakingDetails`](types::StakingDetails)
/// - Value: [`StakingDetails`]
Copy link
Collaborator Author

@aramikm aramikm Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated due to 1.90 required linting guidelines

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jan 8, 2026
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jan 8, 2026
Copy link
Collaborator

@JoeCap08055 JoeCap08055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great--one comment:

In the past, we've explicitly mirrored the SchemaIds from Mainnet onto Testnet by setting storage directly; then we set the max_schema_id on Testnet to 16000 so that any new schemas created won't interfere with the numeric ID space mirrored from Mainnet.

Do we want to continue this practice?
Or--since that practice was conceived before we had name resolution on-chain--do we no longer need it? Is there any advantage any longer to maintaining numeric ID parity between Testnet and Mainnet?

@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jan 8, 2026
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jan 8, 2026
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jan 8, 2026
@aramikm
Copy link
Collaborator Author

aramikm commented Jan 8, 2026

Looks great--one comment:

In the past, we've explicitly mirrored the SchemaIds from Mainnet onto Testnet by setting storage directly; then we set the max_schema_id on Testnet to 16000 so that any new schemas created won't interfere with the numeric ID space mirrored from Mainnet.

Do we want to continue this practice? Or--since that practice was conceived before we had name resolution on-chain--do we no longer need it? Is there any advantage any longer to maintaining numeric ID parity between Testnet and Mainnet?

I think for now we can just create it as is using the script as is but after the release on mainnet and creation of those schemas on mainnet and getting their actual ids. We can always modify the testnet to reflect the mainnet in case we feel it's necessary. But I think having different ids should be fine since we usually handle it based on the environment.

Copy link
Collaborator

@JoeCap08055 JoeCap08055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! 👍

Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@aramikm aramikm merged commit 454313c into main Jan 9, 2026
93 of 95 checks passed
@aramikm aramikm deleted the ics_schemas branch January 9, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metadata-changed Metadata has changed since the latest full release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants