fix: forward bufsize option in export/3 recursive call#32
Merged
frerich merged 2 commits intofrerich:mainfrom Apr 27, 2026
Merged
Conversation
When export/3 is called without :into, it opens a StringIO buffer and recurses with into: set. The bufsize option was not forwarded, causing LargeObject.open/3 to silently fall back to the 65_536 default instead of using the configured value.
Contributor
Author
|
@frerich could you have a look into this? |
frerich
approved these changes
Apr 27, 2026
Owner
frerich
left a comment
frerich
left a comment
There was a problem hiding this comment.
Good catch, thanks a lot for the patch!
Owner
|
@mbaertschi I just released version 0.2.5 of this library, including your bugfix: https://hex.pm/packages/pg_large_objects/0.2.5 Thanks again! |
Contributor
Author
|
Nice, thank you as well for the quick merge! |
mbaertschi
deleted the
fix/export-bufsize-not-forwarded-in-recursive-call
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When export/3 is called without :into, it opens a StringIO buffer and
recurses with into: set. The bufsize option was not forwarded, causing
LargeObject.open/3 to silently fall back to the 65_536 default instead
of using the configured value.