Test warnings as errors#3
Conversation
And failing on some umbrella jobs.
|
Unfortunately the |
kamilkowalski
left a comment
kamilkowalski
left a comment
There was a problem hiding this comment.
Thanks for contributing, sorry I didn't see it before - I'll enable watching this repo from now on. I left some comments, let me know what you think.
| mix_compile: | ||
| name: Compile (Erlang/OTP ${{matrix.otp}} | Elixir ${{matrix.elixir}}) | ||
| runs-on: ubuntu-latest | ||
| container: hexpm/elixir:${{ matrix.elixir }}-erlang-${{ matrix.otp }}-alpine-3.11.6 |
There was a problem hiding this comment.
I recommend using the erlef/setup-elixir action instead - it sets up rebar and hex for you and is the official action that sets up Elixir. Plus I think GH Actions are faster when not containerized, but that might be anecdata. Here's an example that worked for me: https://github.com/elixir-grpc/grpc/pull/189/files
| :modular | ||
| |> Application.fetch_env!(:areas) | ||
| |> Enum.filter(&Code.ensure_compiled?/1) | ||
| |> Enum.filter(fn area -> Code.ensure_compiled(area) == {:module, area} end) |
There was a problem hiding this comment.
We've just changed this code, can you pull the origin?
2 participants
No description provided.