Fix workflows#61
Conversation
emancu
force-pushed
the
fix_workflows
branch
6 times, most recently
from
aebca1b to
06f79de
Compare
| # In Elixir 1.14+, Timex.shift/2 upgrades datetime precision to microseconds. | ||
| # This caused datetimes like ~U[2023-01-01 10:00:00Z] to become ~U[2023-01-01 10:00:00.000000Z] | ||
| # which breaks Ecto validations and equality checks. | ||
| describe "date_and_offset_to_datetime/3 precision" do |
There was a problem hiding this comment.
It should not add anything new functionally, but I would add a test with the Daylight Saving Time change
There was a problem hiding this comment.
I will cover this in the other PR 👍
Paritosh-Anand
left a comment
Paritosh-Anand
left a comment
There was a problem hiding this comment.
There are lot of drifts in the pipeline as compared to other elixir packages ex. https://github.com/surgeventures/credo-checks/blob/master/.github/workflows/elixir-checks.yaml
My suggestion would be to update the pipeline and make it similar to credo-checks to standardize the pipeline.
emancu
force-pushed
the
fix_workflows
branch
6 times, most recently
from
15eaf1c to
d41560e
Compare
|
Im disabling the stupid |
🤔 But CI is failing on |
Paritosh-Anand
force-pushed
the
fix_workflows
branch
from
92dbb58 to
6bcaaa3
Compare
Paritosh-Anand
force-pushed
the
fix_workflows
branch
4 times, most recently
from
7a067f1 to
13b8980
Compare
| @@ -5,7 +5,7 @@ defmodule Surgex.Mixfile do | |||
| [ | |||
| app: :surgex, | |||
| version: "5.0.0", | |||
There was a problem hiding this comment.
Pls remember to bump the version before merging.
Version 5.0.0 is already published
There was a problem hiding this comment.
Maybe I dont want to release immediately.. 👍 So the pipeline should prevent this
Paritosh-Anand
force-pushed
the
fix_workflows
branch
from
13b8980 to
2eea422
Compare
There was a problem hiding this comment.
I dont know what is this, i will revisit later and delete if possible
| defp shift_datetime(datetime, offset) do | ||
| case Timex.shift(datetime, seconds: offset) do | ||
| %NaiveDateTime{} = datetime -> {:ok, datetime} | ||
| %NaiveDateTime{} = shifted -> {:ok, NaiveDateTime.truncate(shifted, :second)} |
3 participants
Seems to be abandoned, so i need to update the workflows and since i am here.. dependencies.