fix(vite): use manifest entry filename for server entry import#3595
Merged
Conversation
…the 'server-entry' entry file.
Contributor
marvinhagemeister
left a comment
marvinhagemeister
left a comment
There was a problem hiding this comment.
Nice, let's add a test for that
Contributor
marvinhagemeister
left a comment
marvinhagemeister
left a comment
There was a problem hiding this comment.
Nice catch! Let's add a test case for this
bartlomieju
changed the title
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verify that when rollupOptions.output.entryFileNames is customized, the generated server.js imports from the actual manifest filename instead of the hardcoded "server-entry.mjs". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bartlomieju
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
rollupOptions.output.entryFileNamesis customized in vite config (e.g.[hash].mjs), the generatedserver.jswas hardcodingserver-entry.mjsas the import path, causing the server to fail to start.This fix reads the actual entry filename from the Vite manifest and uses it in the generated
server.jsimport, falling back toserver-entry.mjswhen no custom naming is configured.Changes
isEntryfile path from the Vite manifest inwriteBundleserver.jsentryFileNamesproduces correctserver.jsimportTest plan
vite build - custom rollup entryFileNames in server.jsverifies the generatedserver.jsuses the hashed filename instead of hardcodedserver-entry.mjs