feat: add vscode files on init#367
Merged
lucacasonato merged 2 commits intoJul 4, 2022
Merged
Conversation
lucacasonato
reviewed
Jul 3, 2022
lucacasonato
left a comment
lucacasonato
left a comment
Member
There was a problem hiding this comment.
Maybe should be locked behind a "Do you use VS Code?" prompt.
excessivecoding
force-pushed
the
feat/add-vscode-file-on-init
branch
from
5540d6e to
8518f62
Compare
Contributor
Author
|
Good call 👍 |
lucacasonato
force-pushed
the
feat/add-vscode-file-on-init
branch
from
8518f62 to
778eb03
Compare
GuillaumeBibaut
pushed a commit
to GuillaumeBibaut/fresh
that referenced
this pull request
Jul 6, 2022
Ask the user if they use VS Code, and if so add the `.vscode/` files. Co-authored-by: Luca Casonato <hello@lcas.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm guessing a lot of people are coming to Fresh without any knowledge on Deno or never used Deno before.
This PR will add some VSCode files to ease their way into the framework by recommanding the Deno extension and enable Deno's extension by default when they open the project for the first time.
Related issue: #364