Skip to content

Support kebab-case filenames for islands#404

Merged
lucacasonato merged 6 commits into
freshframework:mainfrom
delanebob:main
Jul 6, 2022
Merged

Support kebab-case filenames for islands#404
lucacasonato merged 6 commits into
freshframework:mainfrom
delanebob:main

Conversation

@delanebob

@delanebob delanebob commented Jul 4, 2022

Copy link
Copy Markdown
Contributor

A fix for the issue linked below:
#394

@lucacasonato lucacasonato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@delanebob

Copy link
Copy Markdown
Contributor Author

@lucacasonato just added the test there. I added it into the Ensure 2 islands on 1 page are revived test.

Let me know if that's ok or if you'd prefer for me to split it out into it's own separate step.

@lucacasonato lucacasonato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lucacasonato lucacasonato merged commit a7b198f into freshframework:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants