[4.X] Make each module own their DB migration scripts#266
Merged
Conversation
They are validated by the app commands/components module separately
Note that PostgreSQL is the only supported DB for the application commands cache It doesn't make sense to support using a file-based or in-memory database, and no one will go through the effort to host a remote H2 instance
As it's not officially supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Upgrading from 3.X
Here I will explain the details of how it is done, then you will get the corresponding code to migrate in one go.
Moving the data to the new schema(s)
Considering you have used the migration code from "Using a database - Migrating the framework schema", this is how you can migrate your existing data to the new structure:
locationsarguments withbc_database_scripts/genericandbc_database_scripts/<vendor>where<vendor>is eitherpostgresqlorH2ALTER TABLE SET SCHEMAbc_componentsandbc_commands_appAdding migration code for the new modules
For instructions on migrating the schema of relevant modules, see:
BComponentsConfigfor componentsBApplicationConfigBuilder#databaseCacheif you use the database-backed application commands cache (it doesn't by default)For the first run, you will need to replace the
migrate()call withbaseline(), after it is done, revert tomigrate(), done!Doing it in one go
Important
This assumes you have updated to 4.X and added both the
BotCommands-componentsandBotCommands-commands-appmodulesSuppose your existing code is:
To do the whole migration, replace it with: