memoize only when the computed value is not null fixes #53#54
Closed
cosmosgenius wants to merge 1 commit intofrida:masterfrom
Closed
memoize only when the computed value is not null fixes #53#54cosmosgenius wants to merge 1 commit intofrida:masterfrom
cosmosgenius wants to merge 1 commit intofrida:masterfrom
Conversation
|
@oleavr this fixes it |
Member
|
Thanks! Wasn't able to review this until now as I was refactoring surrounding code. I realized this was slightly more complicated, so I implemented a different solution it in 4de996c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The getApi function was getting memoize for the return value
nullas mentioned in the issue #53. This PR checks if the returned value of the compute function is null or not and if it is then doesn't memoize.