Change Handler trait to receive message by value#219
Merged
s1341 merged 1 commit intofrida:mainfrom Oct 8, 2025
Merged
Conversation
BREAKING CHANGE: the Handler trait is public and for user to impl, change signature of trait method is a BREAKING CHANGE. But the change (both for us and for user) is really sample, according to the discusion in frida#217, it is worth trying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #217, there’s no reason the message handler should only receive a reference to the message. Passing the value directly is more idiomatic in Rust and helps reduce memory allocation within the handler.
Although the Handler trait is public and changing the signature of its method constitutes a breaking change, the modification—both for us and for users—is straightforward. I believe it’s worth pursuing.