Conversation
y9san9
force-pushed
the
feat/notifications/add-firebase-notifications
branch
from
c2a9dd2 to
41b7695
Compare
y9san9
force-pushed
the
feat/notifications/add-firebase-notifications
branch
from
41b7695 to
ea2696e
Compare
y9san9
force-pushed
the
feat/notifications/add-firebase-notifications
branch
from
b5bf2ad to
0898a24
Compare
demndevel
reviewed
Feb 2, 2026
| com.google.firebase.messaging.FirebaseMessagingService() { | ||
|
|
||
| private val client = FriendlyClient.production( | ||
| HttpClient(CIO) { |
Member
There was a problem hiding this comment.
I'm gonna make this client initialization as a singleton in the future
Member
There was a problem hiding this comment.
I'm gonna make this client initialization as a singleton in the future
just a formal comment to mention it in the issue
Member
Author
There was a problem hiding this comment.
Usually you would do that as public properties of a companion object that extends Application. Or some kind of special DI singleton. Just FYI
demndevel
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.