Handle sparse data robustly #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3
Hi @friendly, thanks a lot for this nice package. I am proposing two small improvements in this PR:
CMHtest()because they do not contribute to the test statistics and currently cause the computations to return no results.CMHtest()such that it can work when the variancematrix is singular.
I added also a bunch of tests for
CMHtest. The test cases are courtesy of the https://github.com/PSIAIMS/CAMIS/ project, namely @statasaurus, @DrLynTaylor, @yannickvandendijck and @loganjohnson0. I have tried to appropriately call out their authorship in the test file.Please let me know your comments, looking forward to your review :-)
Best, Daniel