Skip to content

fix(deps): migrate pnpm.overrides from package.json to pnpm-workspace.yaml#665

Merged
marcusrbrown merged 1 commit into
mainfrom
fix/migrate-pnpm-overrides-to-workspace
May 23, 2026
Merged

fix(deps): migrate pnpm.overrides from package.json to pnpm-workspace.yaml#665
marcusrbrown merged 1 commit into
mainfrom
fix/migrate-pnpm-overrides-to-workspace

Conversation

@marcusrbrown
Copy link
Copy Markdown
Collaborator

pnpm v10 stopped reading pnpm.overrides from package.json — every pnpm install was logging:

[WARN] The "pnpm" field in package.json is no longer read by pnpm.
The following keys were ignored: "pnpm.overrides".

Three security pins (fast-uri, fast-xml-builder, ip-address) were silently NOT enforced. fast-xml-parser was double-defined — package.json had >=5.7.0 (the CVE-2026-41650 fix from PR #541) but pnpm-workspace.yaml had the looser >=5.5.7; the looser constraint was the live one because the package.json side was ignored. The lockfile happened to resolve to 5.7.2 so the security pin was incidentally honored, but any future regression to <5.7.0 would have gone undetected.

Changes:

  • Moved fast-uri, fast-xml-builder, ip-address from package.json pnpm.overrides into pnpm-workspace.yaml overrides
  • Tightened fast-xml-parser in pnpm-workspace.yaml from >=5.5.7 to >=5.7.0 (restoring the CVE-2026-41650 pin to enforcement)
  • Removed the empty pnpm block from package.json
  • Refreshed pnpm-lock.yaml

Resolved versions all honor the pins:

  • fast-uri@3.1.2
  • fast-xml-builder@1.2.0
  • fast-xml-parser@5.7.2
  • ip-address@10.2.0

dist/ rebuilt — chunk hash rotated and licenses.txt reflects the new resolved versions; main.js/post.js same byte size (no runtime change). Lint and types clean; pnpm install no longer warns.

….yaml

pnpm v10 stopped reading package.json pnpm.overrides — three security pins (fast-uri, fast-xml-builder, ip-address) were silently unenforced and fast-xml-parser was double-defined with the looser constraint winning. Migrate all four into pnpm-workspace.yaml, tighten fast-xml-parser to >=5.7.0 to restore the CVE-2026-41650 pin, refresh the lockfile, rebuild dist/.
Copy link
Copy Markdown
Owner

@fro-bot fro-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: PASS

This is a correct and well-scoped migration. The root cause (pnpm v10 silently ignoring package.json pnpm.overrides) is real, the fix is appropriate, and the lockfile confirms all four security pins are now actively enforced at the correct versions.

Key findings:

  • pnpm-workspace.yaml now consolidates all overrides. The four migrated entries (fast-uri, fast-xml-builder, fast-xml-parser, ip-address) are present and the fast-xml-parser constraint is correctly tightened from >=5.5.7>=5.7.0 to restore the CVE-2026-41650 pin.
  • Lockfile resolves to: fast-uri@3.1.2, fast-xml-builder@1.2.0, fast-xml-parser@5.7.2, ip-address@10.2.0 — all satisfy their respective floor constraints.
  • package.json pnpm block is fully removed (no stale override entries left behind).
  • dist/ rebuild is consistent with a pure dependency version change: chunk hash rotation and licenses.txt delta, no runtime behavior change.

Blocking issues

None

Non-blocking concerns

None

Missing tests

None — this is a dependency configuration change with no testable runtime behavior delta. The lockfile itself is the verification artifact.

Risk assessment (LOW):

Regression risk is low. The change moves from a broken enforcement state to a correctly enforced one. All resolved versions already satisfied the pins before this PR (the lockfile happened to pick safe versions), so there is no observable runtime change. The only risk would be if a future pnpm install now forces a version bump on one of the pinned packages — but that's the intended behavior of the security overrides.


Run Summary
Field Value
Event pull_request
Repository fro-bot/agent
Run ID 26339749915
Cache hit
Session ses_1a9fd344dffemYLdk7r6TX47pW

@marcusrbrown marcusrbrown merged commit 2c11789 into main May 23, 2026
10 checks passed
@marcusrbrown marcusrbrown deleted the fix/migrate-pnpm-overrides-to-workspace branch May 23, 2026 18:25
@fro-bot fro-bot mentioned this pull request May 24, 2026
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants