Skip to content

ci(renovate): clarify Node docker digest commit text#679

Merged
marcusrbrown merged 1 commit into
mainfrom
red-arrogant-felidae
May 28, 2026
Merged

ci(renovate): clarify Node docker digest commit text#679
marcusrbrown merged 1 commit into
mainfrom
red-arrogant-felidae

Conversation

@marcusrbrown
Copy link
Copy Markdown
Collaborator

No description provided.

@marcusrbrown marcusrbrown self-assigned this May 28, 2026
@marcusrbrown marcusrbrown requested a review from fro-bot as a code owner May 28, 2026 03:56
Copy link
Copy Markdown
Owner

@fro-bot fro-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: PASS

The new entry correctly narrows the commit message for Node.js Docker digest-only updates to produce clearer output like build(deps): bump Node.js to 20@abc1234 instead of the generic digest hash message Renovate would otherwise generate.

Correctness check:

  • — consistent with the existing docker rule above it; no conflict since this rule is more specific (package name + update type filters apply first in Renovate's rule-merging).
  • Regex /^((docker[.]io/library/)?node|library/node)$/ — covers the three canonical forms Renovate uses for the official Node image (node, docker.io/library/node, library/node). Correct.
  • matchUpdateTypes: ['digest'] — scoped to digest-only bumps as intended. minor/patch version updates will keep the default commit message. Correct.
  • commitMessageExtra: 'to {{currentValue}}@{{newDigestShort}}'currentValue will be the tag (e.g. 20 or 20-alpine) and newDigestShort the short digest. Produces readable, unambiguous messages.
  • Rule ordering: placed before the broader package-name block; Renovate merges all matching rules in order, so the semanticCommitType: 'build' from the datasource rule above still applies. No conflict.

Blocking issues

None

Non-blocking concerns

None

Missing tests

None — Renovate config changes are validated by the Renovate schema and integration; no unit tests apply here.

Risk assessment (LOW/MED/HIGH): LOW

This is a purely cosmetic change to commit message formatting for a specific, narrow match condition. It cannot break any workflow, dependency update, or runtime behavior.


Run Summary
Field Value
Event pull_request
Repository fro-bot/agent
Run ID 26553747174
Cache hit
Session ses_1934405e3ffefDSLq5jC1NzaEn

Copy link
Copy Markdown
Owner

@fro-bot fro-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: PASS

The new packageRules entry correctly narrows the commit message for Node.js Docker digest-only updates to produce clearer output like build(deps): bump Node.js to 20@abc1234 instead of the generic digest hash message Renovate would otherwise generate.

Correctness check:

  • matchDatasources: ['docker'] — consistent with the existing docker rule above it; no conflict since this rule is more specific (package name + update type filters apply first in Renovate's rule-merging).
  • Regex /^((docker[.]io/library/)?node|library/node)$/ — covers the three canonical forms Renovate uses for the official Node image (node, docker.io/library/node, library/node). Correct.
  • matchUpdateTypes: ['digest'] — scoped to digest-only bumps as intended. minor/patch version updates will keep the default commit message. Correct.
  • commitMessageExtra: 'to {{currentValue}}@{{newDigestShort}}'currentValue will be the tag (e.g. 20 or 20-alpine) and newDigestShort the short digest. Produces readable, unambiguous messages.
  • Rule ordering: placed before the broader package-name block; Renovate merges all matching rules in order, so the semanticCommitType: 'build' from the datasource rule above still applies. No conflict.

Blocking issues

None

Non-blocking concerns

None

Missing tests

None — Renovate config changes are validated by the Renovate schema and integration; no unit tests apply here.

Risk assessment (LOW/MED/HIGH): LOW

This is a purely cosmetic change to commit message formatting for a specific, narrow match condition. It cannot break any workflow, dependency update, or runtime behavior.


Run Summary
Field Value
Event pull_request
Repository fro-bot/agent
Run ID 26553747174
Cache hit
Session ses_1934405e3ffefDSLq5jC1NzaEn

@marcusrbrown marcusrbrown merged commit 1871d7e into main May 28, 2026
10 checks passed
@marcusrbrown marcusrbrown deleted the red-arrogant-felidae branch May 28, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants