docs: capture the unit-green-is-not-feature-done workflow lesson#91
Merged
Conversation
Multi-PR operator UI shipped unit-green across many PRs but the live /operator page stayed a mock skeleton — the SSR shell kept rendering fixtures the client never replaced. Document the surface-verification gate: render and look at the assembled page before calling a user-facing feature done, not just the unit suite.
fro-bot
approved these changes
Jun 24, 2026
fro-bot
left a comment
fro-bot
left a comment
Owner
There was a problem hiding this comment.
Verdict: PASS
Blocking issues
None
Non-blocking concerns
None
Missing tests
None. This PR only adds a docs/solutions workflow lesson and does not change runtime behavior, API contracts, auth, dependencies, or CI.
Risk assessment (LOW/MED/HIGH) + rationale
LOW. The change is documentation-only, matches the existing solution-doc frontmatter/category pattern, and introduces no executable code or security-sensitive surface.
Run Summary
| Field | Value |
|---|---|
| Event | pull_request |
| Repository | fro-bot/dashboard |
| Run ID | 28069706162 |
| Cache | hit |
| Session | ses_108aaf921ffeHBGBNPzSN6NhkK |
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captures a workflow lesson from the operator-UI work: the live
/operatorpage reached production as a mock skeleton even though every contributing PR was unit-green. The SSR shell kept rendering #26's fixtures (ALL_FIXTURE_RUNS/FIXTURE_RUN_TIMELINE+ "Mock skeleton" copy) and the live client was bolted on top, attached to fixture run IDs — and no unit test asserts against the assembled page, so nothing caught it.The doc adds a surface-verification gate to the definition of done: render and look at the assembled page (locally or on a deploy preview), grep the SSR source for fixture/mock leftovers when adding live behavior, trace data origin end to end, and separate "capability shipped" from "surface shipped" in status. The one-line prevention: open the page.
docs/solutions/workflow-issues/(knowledge track), ESLint-excluded.